Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cider-clojurec-eval-destination custom variable #3387

Merged
merged 1 commit into from
Aug 1, 2023
Merged

Add cider-clojurec-eval-destination custom variable #3387

merged 1 commit into from
Aug 1, 2023

Conversation

garrett-hopper
Copy link
Contributor

@garrett-hopper garrett-hopper commented Jul 31, 2023

Adds a cider-clojurec-repl-type-override variable to allow overriding the default behavior of sending CLJC evals to both CLJ and CLJS.

Also includes a cider-set-clojurec-repl-type-override function to prompt the user to set this variable local to the buffer


Before submitting the PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):

  • The commits are consistent with our contribution guidelines
  • You've added tests (if possible) to cover your change(s)
  • All tests are passing (eldev test)
  • All code passes the linter (eldev lint) which is based on elisp-lint and includes
  • You've updated the changelog (if adding/changing user-visible functionality)
  • You've updated the user manual (if adding/changing user-visible functionality)

Thanks!

If you're just starting out to hack on CIDER you might find this section of its
manual
extremely useful.

Copy link
Member

@vemv vemv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks much!

I mainly suggested removing the nil choice which can simplify things.

Cheers - V

CHANGELOG.md Outdated Show resolved Hide resolved
cider-connection.el Outdated Show resolved Hide resolved
cider-connection.el Outdated Show resolved Hide resolved
cider-connection.el Outdated Show resolved Hide resolved
cider-connection.el Outdated Show resolved Hide resolved
cider-connection.el Outdated Show resolved Hide resolved
cider-connection.el Outdated Show resolved Hide resolved
@bbatsov
Copy link
Member

bbatsov commented Aug 1, 2023

The new defcustom should also be mentioned in the user manual.

cider-connection.el Outdated Show resolved Hide resolved
@garrett-hopper
Copy link
Contributor Author

The new defcustom should also be mentioned in the user manual.

Where should this be added exactly?
https://github.com/clojure-emacs/cider/edit/master/doc/modules/ROOT/pages/basics/clojurescript.adoc seems to not exist on master.

cider-connection.el Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
cider-connection.el Outdated Show resolved Hide resolved
@bbatsov
Copy link
Member

bbatsov commented Aug 1, 2023

Apart from my small remarks the changes look good. You might also want to squash those commits together.

@garrett-hopper
Copy link
Contributor Author

Commits squashed 🙂

Copy link
Member

@vemv vemv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last thing and it's in 👍

doc/modules/ROOT/pages/cljs/up_and_running.adoc Outdated Show resolved Hide resolved
@vemv vemv merged commit be224e3 into clojure-emacs:master Aug 1, 2023
11 checks passed
@vemv vemv changed the title Add cider-clojurec-repl-type-override Add cider-clojurec-eval-destination custom variable Aug 3, 2023
@vemv vemv changed the title Add cider-clojurec-eval-destination custom variable Add cider-clojurec-eval-destination custom variable Aug 3, 2023
@garrett-hopper garrett-hopper deleted the cider-clojurec-repl-type-override branch August 18, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants